[PATCH] D11785: [llvm-symbolizer] Remove underscores and other C mangling on Windows

Alexey Samsonov vonosmas at gmail.com
Wed Aug 5 16:11:30 PDT 2015


samsonov added inline comments.

================
Comment at: tools/llvm-symbolizer/LLVMSymbolize.cpp:226
@@ -180,1 +225,3 @@
       }
+      if (Opts.Demangle && isWin32Module())
+        demangleCOFFExternCFunc(LineInfo);
----------------
This is not the place we demangle the function names - see `LLVMSymbolizer::DemangleName`. At that point we already lose the knowledge of whether the module was ELF, or COFF, or MachO, but is it that important? Also, why doesn't `::UnDecorateSymbolName` work for you?


http://reviews.llvm.org/D11785





More information about the llvm-commits mailing list