[llvm] r244127 - [PM] Remove a failed attempt to port the CallGraph analysis to the new

Chandler Carruth chandlerc at gmail.com
Wed Aug 5 14:04:31 PDT 2015


Author: chandlerc
Date: Wed Aug  5 16:04:31 2015
New Revision: 244127

URL: http://llvm.org/viewvc/llvm-project?rev=244127&view=rev
Log:
[PM] Remove a failed attempt to port the CallGraph analysis to the new
pass manager.

This never worked, and won't ever work. It was actually why I ended up
building the LazyCallGraph set of code which is more more effectively
wired up to the new pass manager. This accidentally got committed when
I was trying to land a cleanup of the code organization in the other
parts of this file. =[ My bad, but fortunately Dave was keen eyed enough
to spot that this code couldn't possibly work. =]

Modified:
    llvm/trunk/include/llvm/Analysis/CallGraph.h
    llvm/trunk/lib/Analysis/IPA/CallGraph.cpp

Modified: llvm/trunk/include/llvm/Analysis/CallGraph.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CallGraph.h?rev=244127&r1=244126&r2=244127&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Analysis/CallGraph.h (original)
+++ llvm/trunk/include/llvm/Analysis/CallGraph.h Wed Aug  5 16:04:31 2015
@@ -292,27 +292,6 @@ private:
   void allReferencesDropped() { NumReferences = 0; }
 };
 
-/// \brief An analysis pass to compute the \c CallGraph for a \c Module.
-///
-/// This class implements the concept of an analysis pass used by the \c
-/// ModuleAnalysisManager to run an analysis over a module and cache the
-/// resulting data.
-class CallGraphAnalysis {
-public:
-  /// \brief A formulaic typedef to inform clients of the result type.
-  typedef CallGraph Result;
-
-  static void *ID() { return (void *)&PassID; }
-
-  /// \brief Compute the \c CallGraph for the module \c M.
-  ///
-  /// The real work here is done in the \c CallGraph constructor.
-  CallGraph run(Module *M) { return CallGraph(*M); }
-
-private:
-  static char PassID;
-};
-
 /// \brief The \c ModulePass which wraps up a \c CallGraph and the logic to
 /// build it.
 ///

Modified: llvm/trunk/lib/Analysis/IPA/CallGraph.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/IPA/CallGraph.cpp?rev=244127&r1=244126&r2=244127&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/IPA/CallGraph.cpp (original)
+++ llvm/trunk/lib/Analysis/IPA/CallGraph.cpp Wed Aug  5 16:04:31 2015
@@ -253,12 +253,6 @@ void CallGraphNode::replaceCallEdge(Call
 }
 
 //===----------------------------------------------------------------------===//
-// Out-of-line definitions of CallGraphAnalysis class members.
-//
-
-char CallGraphAnalysis::PassID;
-
-//===----------------------------------------------------------------------===//
 // Implementations of the CallGraphWrapperPass class methods.
 //
 




More information about the llvm-commits mailing list