Thread premissions through sys::fs::create_director{y|ies}

Aaron Ballman aaron at aaronballman.com
Wed Aug 5 13:18:56 PDT 2015


On Wed, Aug 5, 2015 at 3:06 PM, Frédéric Riss <friss at apple.com> wrote:
> The attached pretty trivial patch thread a permissions argument through sys::fs::create_directories.
> I’m sending it for review regardless of the trivialness for 2 reasons:
>  - I have no idea how to test that. The passed permission are still subject to umask, thus testing the file_status of a created directory in a unittest doesn’t seem possible. Ideas welcome.
>  - I suppose Windows doesn’t care about permissions, thus I just ignored the argument. Is that right?

Windows does care about permissions, however, we ignore them at
present because it doesn't care about permissions in a Unix-like way.

~Aaron


More information about the llvm-commits mailing list