Thread premissions through sys::fs::create_director{y|ies}

Frédéric Riss friss at apple.com
Wed Aug 5 12:06:43 PDT 2015


The attached pretty trivial patch thread a permissions argument through sys::fs::create_directories.
I’m sending it for review regardless of the trivialness for 2 reasons:
 - I have no idea how to test that. The passed permission are still subject to umask, thus testing the file_status of a created directory in a unittest doesn’t seem possible. Ideas welcome.
 - I suppose Windows doesn’t care about permissions, thus I just ignored the argument. Is that right?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: create_directories.patch
Type: application/octet-stream
Size: 4199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150805/80340f1c/attachment.obj>
-------------- next part --------------
 

Fred


More information about the llvm-commits mailing list