[PATCH] Move succ_iterator definition inside TerminatorInst

[Pete Cooper]

> On Aug 5, 2015, at 11:40 AM, Tobias Grosser <tobias at grosser.es> wrote:
> 
> On 08/05/2015 08:33 PM, David Blaikie wrote:
>> 
>> 
>> On Wed, Aug 5, 2015 at 11:28 AM, Tobias Grosser <tobias at grosser.es <mailto:tobias at grosser.es>> wrote:
>> 
>>    On 08/05/2015 07:57 PM, Pete Cooper wrote:
>> 
>> 
>>            On Aug 5, 2015, at 10:55 AM, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com> <mailto:dblaikie at gmail.com <mailto:dblaikie at gmail.com>>> wrote:
>> 
>>            Oh, I hadn't seen the commit. I don't much mind - if no one objected then post-commit review may've been sufficient for this change anyway.
>> 
>>        Yeah, it was really unlucky timing.  Only just committed a few minutes prior to your email.
>> 
>>        Hopefully folks are happy with post commit.  I’m more than happy to revert if there are any issues with the patch.  I’ll hold off on making use of this new code until at least tomorrow to give everyone a chance to comment.
>> 
>> 
>>    David, thank you for pointing this out. I did also not realize llvm-commits
>>    is not copied.
>> 
>>    There is a related LLVM bug to ensure people don't forget to add the relevant
>>    mailing lists, but it does not seem trivial to fix:
>> 
>>    https://llvm.org/bugs/show_bug.cgi?id=23920
>> 
>> 
>> Yep. (Though this wasn't even a phab review, I don't think - all good though, these things happen sometimes (it's just really easy for me to spot because all llvm mail goes into filtered folders - if it's not sent to a mailing list then it reaches my inbox which is very noticable (not many things reach my inbox directly)))
> 
> Alright. Now I got it. Yes, sorry for not spotting it earlier. As you said,
> post-commit review should take care of this, but next time I willdefinitely
> pay more attention to this.
Ultimately this one is my fault.  I CCed so many people specifically, that I forgot the list.  It doesn’t happen often, but i’ll still try make sure i don’t do it again.

Also my fault CCing the wrong llvm-commits when David pointed out it wasn’t CCed at all.  No wonder I just got a bounce from uiuc!
> 
> Thanks again,
> Tobias
>