[PATCH] D11072: Implement tool to convert bitcode to text.

Karl Schimpf kschimpf at google.com
Wed Aug 5 10:54:58 PDT 2015


kschimpf added a comment.

I'm a bit confused on naming conventions. lib/Bitcode represents multiple libraries:

  lib/Bitcode/Reader
  lib/Bitcode/Writer

I assume that they are contained in lib/Bitcode because they represent Bitcode, bitcode records, and the corresponding bitstreams.

Similarly, the bitcode converter reads/writes bitcode records without converting to IR, or starting with IR. Rather, it only uses the (same) bitcode records that the bitcode reader and writer use. For this reason, I created a separate library lib/Bitcode/Convert.

Are you suggesting that I should (instead) create a separate directory lib/BitcodeConvert, even though lib/Bitcode defines bitcode records as well?


http://reviews.llvm.org/D11072





More information about the llvm-commits mailing list