[PATCH] D11741: [TTI] Make the cost APIs in TargetTransformInfo consistently use 'int' rather than 'unsigned' for their costs.

Chandler Carruth chandlerc at gmail.com
Mon Aug 3 18:38:48 PDT 2015


chandlerc added a comment.

In http://reviews.llvm.org/D11741#217357, @chandlerc wrote:

> In http://reviews.llvm.org/D11741#217335, @sanjoy wrote:
>
> > I have two comments:
> >
> > - I'd be scared of existing code that returns `-1` to mean "very expensive".  Now that same value means "cheaper than free".  I think these should be fixed, but is there a way to automatically flush these out?
>
>
> Probably, I think I can add some asserts to check for this. But I've also read through most of this code and don't see anyone doing that. Still, better to check.


Done, now with asserts that we don't misuse -1 inside of TTI.


http://reviews.llvm.org/D11741







More information about the llvm-commits mailing list