[PATCH] D11741: [TTI] Make the cost APIs in TargetTransformInfo consistently use 'int' rather than 'unsigned' for their costs.

Sanjoy Das sanjoy at playingwithpointers.com
Mon Aug 3 17:03:09 PDT 2015


sanjoy added a subscriber: sanjoy.
sanjoy added a comment.

I have two comments:

- I'd be scared of existing code that returns `-1` to mean "very expensive".  Now that same value means "cheaper than free".  I think these should be fixed, but is there a way to automatically flush these out?
- Do you intend to add callbacks that actually return negative costs?  Or is this meant to make intermediate computation more ergonomic?


http://reviews.llvm.org/D11741







More information about the llvm-commits mailing list