[PATCH] D11691: [WebAssembly] Add Relooper

JF Bastien jfb at chromium.org
Mon Aug 3 15:22:50 PDT 2015


jfb added inline comments.

================
Comment at: lib/Target/WebAssembly/Relooper.cpp:98
@@ +97,3 @@
+                Target)); // cannot add more than one branch to the same target
+  BranchesOut[Target] = std::unique_ptr<Branch>(new Branch(Condition, Code));
+}
----------------
`STLExtras.h` has the sorely-missing `make_unique` for this. Same in a few places below.

================
Comment at: lib/Target/WebAssembly/Relooper.h:28
@@ +27,3 @@
+#include <list>
+#include <memory>
+
----------------
Sort includes alphabetically.


Repository:
  rL LLVM

http://reviews.llvm.org/D11691







More information about the llvm-commits mailing list