[PATCH] D11143: [RFC] Cross Block DSE

hfinkel at anl.gov hfinkel at anl.gov
Mon Aug 3 15:16:18 PDT 2015


hfinkel added a comment.

Danny, are you okay with the algorithm at this point?


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1001
@@ +1000,3 @@
+        uint64_t MemSize = AA->getTypeStoreSize(MemPtr->getType());
+        AliasResult R = AA->alias(Pointer, PtrSize, MemPtr, MemSize);
+        if (R == MustAlias)
----------------
If I'm reading this correctly, this call to AA->alias is going to essentially re-do all of the same analysis done in the AA->getModRefInfo call above. Could we check whether I is a StoreInst first and only to one query on store instructions instead of two?



http://reviews.llvm.org/D11143







More information about the llvm-commits mailing list