[PATCH] D11691: [WebAssembly] Add Relooper
JF Bastien
jfb at chromium.org
Mon Aug 3 12:59:45 PDT 2015
jfb added inline comments.
================
Comment at: lib/Target/WebAssembly/Relooper.cpp:525
@@ +524,3 @@
+ Block *Curr = *(Entries->begin());
+ if (Curr->BranchesIn.size() == 0) {
+ // One entry, no looping ==> Simple
----------------
arsenm wrote:
> .empti() would be preferrable
Agreed on using `.empty()` instead of `.size() == 0` in a few places.
================
Comment at: lib/Target/WebAssembly/Relooper.cpp:656
@@ +655,3 @@
+ (void) Simple; \
+ simple; \
+ } \
----------------
`break;` here and below.
Repository:
rL LLVM
http://reviews.llvm.org/D11691
More information about the llvm-commits
mailing list