[PATCH] D11681: [asan] Print VAs instead of RVAs for module offsets on Windows

Reid Kleckner rnk at google.com
Mon Aug 3 11:24:49 PDT 2015


rnk marked 5 inline comments as done.
rnk added a comment.

In http://reviews.llvm.org/D11681#216265, @samsonov wrote:

> LGTM. I'm slightly worried about existing clients who might depend on ASan stack traces containing RVAs. Does it mean that they should just drop "--relative-address" flag from their llvm-symbolizer.exe invocation? If yes, please specify this in the commit message.


Sure. I think Chromium clusterfuzz is the only client of this flag, and I'll talk to them when I look at rolling clang.


http://reviews.llvm.org/D11681







More information about the llvm-commits mailing list