[PATCH] D11316: [X86] -- Fix fptoui i64 conversions for IA32 (performance and correctness)
David Majnemer
david.majnemer at gmail.com
Sat Aug 1 23:59:14 PDT 2015
majnemer added a subscriber: majnemer.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:26320
@@ -26204,2 +26319,3 @@
bool X86TargetLowering::isTargetFTOL() const {
- return Subtarget->isTargetKnownWindowsMSVC() && !Subtarget->is64Bit();
+ // FTOL usage is currently incorrect, as it computes conversion
+ // to *signed* i64, so it is disabled here. Given the presence
----------------
mkuper wrote:
> I'm ok with just deleting the FTOL code immediately, unless anyone objects.
> (Can be a follow-up patch)
I think it makes sense to remove it.
http://reviews.llvm.org/D11316
More information about the llvm-commits
mailing list