[PATCH] Bitcode: Add bitcode format compatibility test

Vedant Kumar vsk at apple.com
Fri Jul 31 10:42:07 PDT 2015


>> -* The bitcode format produced by a X.Y release will be readable by all following
>> -  X.Z releases and the (X+1).0 release.
>> +* The bitcode format produced by a X.Y release will be readable by all
>> +  following X.Z releases and the (X+1).0 release. To help ensure this, an X.Y
>> +  version of ``test/Bitcode/compatibility.ll`` should be assembled and
>> +  committed before each release.
> 
> s/before/after/

Done.


>> * Newer releases can ignore features from older releases, but they cannot
>>   miscompile them. For example, if nsw is ever replaced with something else,
> 
> Please also add a point (maye earlier?) stating that new/changed IR constructs
> should get added to test/Bitcode/compatibility.ll.

Done.


>> diff --git a/test/Bitcode/compatibility.ll b/test/Bitcode/compatibility.ll
>> new file mode 100644
>> index 0000000..46aebba
>> --- /dev/null
>> +++ b/test/Bitcode/compatibility.ll
>> @@ -0,0 +1,1275 @@
>> +; Bitcode compatibility test for llvm-3.7
> 
> This shouldn't mention llvm-3.7; this is for trunk.

Removed reference to 3.7.


> However, it should duplicate the info from docs/DeveloperPolicy.rst (and
> reference it).

Done.

Patch attached --

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bccompat-submit.patch
Type: application/octet-stream
Size: 104026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150731/9db15bb7/attachment.obj>


More information about the llvm-commits mailing list