[RFC] SortedVector ADT

Krzysztof Parzyszek kparzysz at codeaurora.org
Fri Jul 31 09:44:08 PDT 2015


On 7/31/2015 8:27 AM, Aaron Ballman wrote:
>
> I am wondering why this should be an ADT instead of one-off
> functionality. I see that you're going to use it for
> MachineBasicBlock, but are there other use cases as well? The kind of
> functionality that this class provides is covered by basic STL
> mechanisms, and so I am hesitant to support it as an ADT for all of
> our users unless this is something we expect will be heavily used (or
> is heavily customized to support toolchain needs).

I agree.  Also, I think we should avoid creating new ADT unless there is 
a compelling reason to have our own implementation of a container.

-Krzysztof

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation



More information about the llvm-commits mailing list