[PATCH] D11660: [x86] reassociate integer multiplies using machine combiner pass

Sanjay Patel spatel at rotateright.com
Thu Jul 30 16:56:55 PDT 2015


spatel added inline comments.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:6506
@@ -6485,3 +6505,3 @@
       .addReg(RegY, getKillRegState(KillY));
   InsInstrs.push_back(MIB1);
 
----------------
Is it ok that I'm not explicitly adding a dead EFLAGS operand (if this is an integer instruction)? I see that the operand gets added later anyway based on the instruction type, but I wonder if it's poor form to not do it right here.


http://reviews.llvm.org/D11660







More information about the llvm-commits mailing list