[PATCH] D11654: Add a TargetMachine hook that verifies DataLayout compatibility

[Eric Christopher]

echristo added a comment.

This assert will only be valid as long as we create (or can create) a data layout in the backend right?

-eric


================
Comment at: include/llvm/Target/TargetMachine.h:138-141
@@ +137,6 @@
+  ///
+  /// The LLVM Module owns a DataLayout that is used for the target independent
+  /// optimizations and will be used for the CodeGen. This hook provide a target
+  /// specific check on the validity of this DataLayout. The default
+  /// implementation just check for an exact match but Targets can override it.
+  virtual bool isCompatibleDataLayout(const DataLayout &Candidate) const {
----------------
"is used for optimizations and code generation"?
"This hook provides a..."
"The default implementation just checks..." though do we really need a target override here?


http://reviews.llvm.org/D11654