[llvm] r243581 - Reapply "Add reverse(ContainerTy) range adapter."

Charles Davis cdavis5x at gmail.com
Wed Jul 29 19:56:26 PDT 2015


> On Jul 29, 2015, at 6:48 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> 
> Should be fixed by r243581.  Sorry for the breakage.
That fixed the build error, alright (and thanks for the quick turnaround!), but it doesn’t really address the “has_rbegin not quite working right” concern I brought up. I guess it’s OK for `std::vector`, but I’m just afraid we might get strange or broken behavior from this for other containers with overloaded-for-const `rbegin()`/`rend()` methods where `std::reverse_iterator` might not work right. I don’t know if there are any that we need to worry about, though.

Chip





More information about the llvm-commits mailing list