[PATCH] D11618: [CMake] Pass -march=i686 when targeting i686 (PR24222)

[Alexey Samsonov]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you!


================
Comment at: cmake/config-ix.cmake:183
@@ -182,3 +182,3 @@
       # be gone after we resolve PR14109.
-      test_target_arch(i686 __i686__ "-m32")
+      test_target_arch(i686 __i686__ "-m32" "-march=i686")
       test_target_arch(i386 __i386__ "-m32")
----------------
Please mention PR24222 in a comment here.

================
Comment at: test/sanitizer_common/TestCases/Linux/open_memstream.cc:2
@@ -3,1 +1,3 @@
+// RUN: %clangxx -m64 -march='' -O0 -g -xc++ %s -o %t && %run %t
+// RUN: %clangxx -m64 -march='' -O3 -g -xc++ %s -o %t && %run %t
 // REQUIRES: x86_64-supported-target
----------------
Would `-march=x86_64` work here?


http://reviews.llvm.org/D11618