[PATCH] D10548: Teach LTOModule to emit linker flags for dllexported symbols, plus interface cleanup.

Yunzhong Gao Yunzhong_Gao at playstation.sony.com
Wed Jul 29 18:01:12 PDT 2015


ygao added a comment.

Hi Peter,
I'd like to point out a corner case:

  #pragma comment(lib, "lib1\00lib2")
  #pragma comment(lib, "lib3")

Testing on Visual Studio 2013, the intended behavior should be to auto-link with lib1.lib and lib3.lib,
but not lib2.
With the new LTO API, looking at the return value from lto_module_get_linkeropts(), the embedded
null character after lib1 seems to remove lib3 from the library list.

I am guessing that the fix is probably to make ParsePragma truncate the first string earlier,

- Gao


http://reviews.llvm.org/D10548







More information about the llvm-commits mailing list