[PATCH] D11579: [InstrProfiling] Fix data race on profile counters by using AtomicRMW.

Diego Novillo dnovillo at google.com
Wed Jul 29 15:38:19 PDT 2015


dnovillo added a comment.

In http://reviews.llvm.org/D11579#214650, @samsonov wrote:

> What kind of uses do you refer to? InstrProfIncrementInst we're replacing has type "void", so it doesn't return any value that can be consumed.


Yeah, that's what's confusing me.  Why was the code before calling RAUW?

Other than that, your change looks fine to me.  But there's clearly something I'm not quite understanding here.  I'd like Justin to chime in.


http://reviews.llvm.org/D11579







More information about the llvm-commits mailing list