[PATCH] MIR Serialization: Serialize the machine basic block successor weights.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Jul 29 15:18:38 PDT 2015


> On 2015-Jul-29, at 10:49, Alex L <arphaman at gmail.com> wrote:
> 
> Thanks for the review,
> 
> I would actually prefer to keep the successors and weights separate - I've
> attached a patch below that uses the following syntax:
> 
>    successors: [ '%bb.1.less', '%bb.2.exit' ]
>    weights:       [ 16, 16 ]
> 
> I prefer this syntax more than the one you proposed, as with this syntax
> all the MBB references have a consistent syntax that only has the references,
> without any additional attributes. Also, I think that for the majority of the
> test cases, the weights aren't really important, so the person who's writing
> the test by basing it off the output of LLC can simply remove the line with the
> weights instead of removing every weight attribute in each successor.
> 

This looks better.

> <0001-MIR-Serialization-serialize-the-MBB-successor-weight.patch>

LGTM.



More information about the llvm-commits mailing list