[PATCH] D11610: [mips][FastISel] Remove hidden mips-fast-isel option.

[Eric Christopher]

echristo added a subscriber: echristo.
echristo added a comment.

Hi, some inline comments :)

-eric


================
Comment at: test/CodeGen/Mips/Fast-ISel/bswap1.ll:2-5
@@ -1,6 +1,6 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32 -O0 -relocation-model=pic \
-; RUN:      -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s \
+; RUN:      -fast-isel=true -fast-isel-abort=1 | FileCheck %s \
 ; RUN:      -check-prefix=ALL -check-prefix=32R1
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 -relocation-model=pic \
-; RUN:      -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s \
+; RUN:      -fast-isel=true -fast-isel-abort=1 | FileCheck %s \
 ; RUN:      -check-prefix=ALL -check-prefix=32R2
----------------
You shouldn't need -fast-isel=true on these lines any more.

================
Comment at: test/CodeGen/Mips/Fast-ISel/div1.ll:2-4
@@ -1,5 +1,5 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32 -O0 -relocation-model=pic \
-; RUN:      -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s
+; RUN:      -fast-isel=true -fast-isel-abort=1 | FileCheck %s
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 -relocation-model=pic \
-; RUN:      -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s
+; RUN:      -fast-isel=true -fast-isel-abort=1 | FileCheck %s
 
----------------
Ditto.

================
Comment at: test/CodeGen/Mips/Fast-ISel/fastcc-miss.ll:2
@@ -1,3 +1,3 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 -relocation-model=pic \
-; RUN:     -fast-isel=true -mips-fast-isel -fast-isel-verbose 2>&1 | \
+; RUN:     -fast-isel=true -fast-isel-verbose 2>&1 | \
 ; RUN:   FileCheck %s
----------------
Ditto.

================
Comment at: test/CodeGen/Mips/Fast-ISel/logopm.ll:1-2
@@ -1,3 +1,3 @@
-; RUN: llc -march=mipsel -relocation-model=pic -O0 -fast-isel -mips-fast-isel -fast-isel-abort=1 -mcpu=mips32r2 < %s | FileCheck %s
-; RUN: llc -march=mipsel -relocation-model=pic -O0 -fast-isel -mips-fast-isel -fast-isel-abort=1 -mcpu=mips32 < %s | FileCheck %s
+; RUN: llc -march=mipsel -relocation-model=pic -O0 -fast-isel -fast-isel-abort=1 -mcpu=mips32r2 < %s | FileCheck %s
+; RUN: llc -march=mipsel -relocation-model=pic -O0 -fast-isel -fast-isel-abort=1 -mcpu=mips32 < %s | FileCheck %s
 
----------------
Ditto.

================
Comment at: test/CodeGen/Mips/Fast-ISel/memtest1.ll:2-5
@@ -1,6 +1,6 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32 -O0 -relocation-model=pic \
-; RUN:     -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s \
+; RUN:     -fast-isel=true -fast-isel-abort=1 | FileCheck %s \
 ; RUN:     -check-prefix=ALL -check-prefix=32R1
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 -relocation-model=pic \
-; RUN:     -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s \
+; RUN:     -fast-isel=true -fast-isel-abort=1 | FileCheck %s \
 ; RUN:     -check-prefix=ALL -check-prefix=32R2
----------------
Again.

================
Comment at: test/CodeGen/Mips/Fast-ISel/mul1.ll:2-4
@@ -1,5 +1,5 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32 -O0 \
-; RUN:    -fast-isel -mips-fast-isel -relocation-model=pic
+; RUN:    -fast-isel -relocation-model=pic
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 \
-; RUN:    -fast-isel -mips-fast-isel -relocation-model=pic
+; RUN:    -fast-isel -relocation-model=pic
 
----------------
Ditto.

================
Comment at: test/CodeGen/Mips/Fast-ISel/rem1.ll:2-4
@@ -1,5 +1,5 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32 -O0 -relocation-model=pic \
-; RUN:      -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s
+; RUN:      -fast-isel=true -fast-isel-abort=1 | FileCheck %s
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 -relocation-model=pic \
-; RUN:      -fast-isel=true -mips-fast-isel -fast-isel-abort=1 | FileCheck %s
+; RUN:      -fast-isel=true -fast-isel-abort=1 | FileCheck %s
 
----------------
Ditto.

================
Comment at: test/CodeGen/Mips/Fast-ISel/sel1.ll:2
@@ -1,3 +1,3 @@
 ; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O2 -relocation-model=pic \
-; RUN:          -fast-isel -mips-fast-isel -fast-isel-abort=1 | FileCheck %s
+; RUN:          -fast-isel -fast-isel-abort=1 | FileCheck %s
 
----------------
Ditto.

================
Comment at: test/CodeGen/Mips/Fast-ISel/shift.ll:1
@@ -1,2 +1,2 @@
-; RUN: llc -march=mipsel -mcpu=mips32r2 -O1 -fast-isel=true -mips-fast-isel -filetype=obj %s -o - \
+; RUN: llc -march=mipsel -mcpu=mips32r2 -O1 -fast-isel=true -filetype=obj %s -o - \
 ; RUN:   | llvm-objdump -arch mipsel -mcpu=mips32r2 -d - | FileCheck %s
----------------
Why -O1 here?

================
Comment at: test/CodeGen/Mips/emergency-spill-slot-near-fp.ll:2
@@ -1,3 +1,3 @@
 ; Check that register scavenging spill slot is close to $fp.
-; RUN: llc -march=mipsel -O0 < %s | FileCheck %s
+; RUN: llc -march=mipsel -O0 -fast-isel=false < %s | FileCheck %s
 
----------------
The typical thing is to just use llc -march here, but I gather optimization makes the testcase go away?

================
Comment at: test/CodeGen/Mips/emergency-spill-slot-near-fp.ll:7
@@ -6,3 +6,3 @@
 
-define i32 @main(i32 signext %argc, i8** %argv) "no-frame-pointer-elim"="true" {
+define i32 @main(i32 signext %argc, i8** %argv) #0 {
 entry:
----------------
Go ahead and clean this up separately.


http://reviews.llvm.org/D11610