D11610: [mips][FastISel] Remove hidden mips-fast-isel option.

[Vasileios Kalintiris]

Thank you Han, that's perfect. CC-ing Daniel too... I think I need some coffee :)
________________________________________
From: hwennborg at google.com [hwennborg at google.com] on behalf of Hans Wennborg [hans at chromium.org]
Sent: 29 July 2015 23:00
To: Vasileios Kalintiris
Cc: qcolombet at apple.com; llvm-commits at cs.uiuc.edu; ehostunreach at gmail.com
Subject: Re: D11610: [mips][FastISel] Remove hidden mips-fast-isel option.

Sounds great. Let me know when this and D11592 lands and we can get it
all merged.

Thanks,
Hans

On Wed, Jul 29, 2015 at 2:55 PM, Vasileios Kalintiris
<Vasileios.Kalintiris at imgtec.com> wrote:
> Sorry for the double mail. I forgot to actually include Han's e-mail.
>
> ________________________________________
> From: Vasileios Kalintiris
> Sent: 29 July 2015 22:51
> To: Craig Hansen-Sturm
> Cc: qcolombet at apple.com; llvm-commits at cs.uiuc.edu; ehostunreach at gmail.com
> Subject: RE: D11610: [mips][FastISel] Remove hidden mips-fast-isel option.
>
> Hello Hans,
>
> With this review request and the following bug-fixes
>
> 1) r243485: [mips][FastISel] Fix call lowering by bailing out on "fastcc" calls.
> 2) r243469: [mips][FastISel] Fix generated code for IR's select instruction.
> 3) [mips][FastISel] Apply only zero-extension to constants prior to their materialization. (http://reviews.llvm.org/D11592 pending LGTM from Daniel)
>
> We are able to bootstrap Clang with FastISel and pass every test from the LLVM test-suite under various and different configurations. Although, we are almost at the end of the RC2 phase, these patches have been tested thoroughly throughout the last 2+ weeks and it would be nice to consider them for the RC branch. I've CC'ed Daniel Sanders if you have any question or need clarification about something.
>
> Thanks,
> Vasileios Kalintiris
>
> ________________________________________
> From: Vasileios Kalintiris
> Sent: 29 July 2015 22:36
> To: Vasileios Kalintiris; Daniel Sanders
> Cc: qcolombet at apple.com; llvm-commits at cs.uiuc.edu; ehostunreach at gmail.com
> Subject: [PATCH] D11610: [mips][FastISel] Remove hidden mips-fast-isel option.
>
> vkalintiris created this revision.
> vkalintiris added a reviewer: dsanders.
> vkalintiris added a subscriber: llvm-commits.
> Herald added a subscriber: qcolombet.
>
> This hidden option would disable code generation through FastISel by
> default. It was removed from the available options and from the
> Fast-ISel tests that required it in order to run the tests.
>
> http://reviews.llvm.org/D11610
>
> Files:
>   lib/Target/Mips/MipsISelLowering.cpp
>   test/CodeGen/Mips/Fast-ISel/br1.ll
>   test/CodeGen/Mips/Fast-ISel/bswap1.ll
>   test/CodeGen/Mips/Fast-ISel/callabi.ll
>   test/CodeGen/Mips/Fast-ISel/constexpr-address.ll
>   test/CodeGen/Mips/Fast-ISel/div1.ll
>   test/CodeGen/Mips/Fast-ISel/fastalloca.ll
>   test/CodeGen/Mips/Fast-ISel/fastcc-miss.ll
>   test/CodeGen/Mips/Fast-ISel/fpcmpa.ll
>   test/CodeGen/Mips/Fast-ISel/fpext.ll
>   test/CodeGen/Mips/Fast-ISel/fpintconv.ll
>   test/CodeGen/Mips/Fast-ISel/fptrunc.ll
>   test/CodeGen/Mips/Fast-ISel/icmpa.ll
>   test/CodeGen/Mips/Fast-ISel/loadstore2.ll
>   test/CodeGen/Mips/Fast-ISel/loadstoreconv.ll
>   test/CodeGen/Mips/Fast-ISel/loadstrconst.ll
>   test/CodeGen/Mips/Fast-ISel/logopm.ll
>   test/CodeGen/Mips/Fast-ISel/memtest1.ll
>   test/CodeGen/Mips/Fast-ISel/mul1.ll
>   test/CodeGen/Mips/Fast-ISel/nullvoid.ll
>   test/CodeGen/Mips/Fast-ISel/overflt.ll
>   test/CodeGen/Mips/Fast-ISel/rem1.ll
>   test/CodeGen/Mips/Fast-ISel/retabi.ll
>   test/CodeGen/Mips/Fast-ISel/sel1.ll
>   test/CodeGen/Mips/Fast-ISel/shftopm.ll
>   test/CodeGen/Mips/Fast-ISel/shift.ll
>   test/CodeGen/Mips/Fast-ISel/simplestore.ll
>   test/CodeGen/Mips/Fast-ISel/simplestorefp1.ll
>   test/CodeGen/Mips/Fast-ISel/simplestorei.ll
>   test/CodeGen/Mips/emergency-spill-slot-near-fp.ll
>