[PATCH] D11608: COFF: Remove the old COFF linker and rename link2 link.

Davide Italiano davide.italiano at gmail.com
Wed Jul 29 14:36:19 PDT 2015 

LGTM

On Wed, Jul 29, 2015 at 2:20 PM, Rui Ueyama <ruiu at google.com> wrote:
> ruiu created this revision.
> ruiu added reviewers: compnerd, rafael.
> ruiu added a subscriber: llvm-commits.
> ruiu set the repository for this revision to rL LLVM.
>
> Now that the new COFF linker is complete, we can make the new
> one as the default linker for "-flavor link".
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D11608
>
> Files:
>   include/lld/Driver/Driver.h
>   include/lld/Driver/WinLinkModuleDef.h
>   include/lld/ReaderWriter/PECOFFLinkingContext.h
>   lib/Driver/CMakeLists.txt
>   lib/Driver/UniversalDriver.cpp
>   lib/Driver/WinLinkDriver.cpp
>   lib/Driver/WinLinkModuleDef.cpp
>   lib/Driver/WinLinkOptions.td
>   lib/ReaderWriter/CMakeLists.txt
>   lib/ReaderWriter/PECOFF/Atoms.h
>   lib/ReaderWriter/PECOFF/CMakeLists.txt
>   lib/ReaderWriter/PECOFF/EdataPass.cpp
>   lib/ReaderWriter/PECOFF/EdataPass.h
>   lib/ReaderWriter/PECOFF/IdataPass.cpp
>   lib/ReaderWriter/PECOFF/IdataPass.h
>   lib/ReaderWriter/PECOFF/InferSubsystemPass.h
>   lib/ReaderWriter/PECOFF/LinkerGeneratedSymbolFile.cpp
>   lib/ReaderWriter/PECOFF/LinkerGeneratedSymbolFile.h
>   lib/ReaderWriter/PECOFF/LoadConfigPass.cpp
>   lib/ReaderWriter/PECOFF/LoadConfigPass.h
>   lib/ReaderWriter/PECOFF/OrderPass.h
>   lib/ReaderWriter/PECOFF/PDBPass.h
>   lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp
>   lib/ReaderWriter/PECOFF/Pass.cpp
>   lib/ReaderWriter/PECOFF/Pass.h
>   lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
>   lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp
>   lib/ReaderWriter/PECOFF/WriterImportLibrary.cpp
>   lib/ReaderWriter/PECOFF/WriterImportLibrary.h
>   lib/ReaderWriter/PECOFF/WriterPECOFF.cpp
>   test/COFF/alternatename.test
>   test/COFF/ar-comdat.test
>   test/COFF/armnt-blx23t.test
>   test/COFF/armnt-branch24t.test
>   test/COFF/armnt-entry-point.test
>   test/COFF/armnt-imports.test
>   test/COFF/armnt-mov32t-exec.test
>   test/COFF/armnt-movt32t.test
>   test/COFF/base.test
>   test/COFF/baserel.test
>   test/COFF/common.test
>   test/COFF/conflict.test
>   test/COFF/debug.test
>   test/COFF/defparser.test
>   test/COFF/delayimports.test
>   test/COFF/delayimports32.test
>   test/COFF/dll.test
>   test/COFF/driver.test
>   test/COFF/entry-inference.test
>   test/COFF/entry-inference2.test
>   test/COFF/entry-inference32.test
>   test/COFF/entry-mangled.test
>   test/COFF/entrylib.ll
>   test/COFF/export.test
>   test/COFF/export32.test
>   test/COFF/failifmismatch.test
>   test/COFF/filetype.test
>   test/COFF/force.test
>   test/COFF/heap.test
>   test/COFF/hello32.test
>   test/COFF/help.test
>   test/COFF/icf.test
>   test/COFF/imports-mangle.test
>   test/COFF/imports.test
>   test/COFF/include.test
>   test/COFF/include2.test
>   test/COFF/internal.test
>   test/COFF/largeaddressaware.test
>   test/COFF/libpath.test
>   test/COFF/linkenv.test
>   test/COFF/lldmap.test
>   test/COFF/loadcfg.test
>   test/COFF/loadcfg32.test
>   test/COFF/locally-imported.test
>   test/COFF/locally-imported32.test
>   test/COFF/long-section-name.test
>   test/COFF/lto-chkstk.ll
>   test/COFF/lto-comdat.ll
>   test/COFF/lto-linker-opts.ll
>   test/COFF/lto-new-symbol.ll
>   test/COFF/lto.ll
>   test/COFF/machine.test
>   test/COFF/manifest.test
>   test/COFF/merge.test
>   test/COFF/nodefaultlib.test
>   test/COFF/noentry.test
>   test/COFF/opt.test
>   test/COFF/options.test
>   test/COFF/order.test
>   test/COFF/out.test
>   test/COFF/reloc-x64.test
>   test/COFF/reloc-x86.test
>   test/COFF/resource.test
>   test/COFF/responsefile.test
>   test/COFF/seh.test
>   test/COFF/stack.test
>   test/COFF/subsystem-inference.test
>   test/COFF/subsystem.test
>   test/COFF/symtab.test
>   test/COFF/tls.test
>   test/COFF/tls32.test
>   test/COFF/unwind.test
>   test/COFF/version.test
>   test/COFF/weak-external.test
>   test/COFF/weak-external2.test
>   test/COFF/weak-external3.test
>   test/pecoff/Inputs/abs.obj.yaml
>   test/pecoff/Inputs/alignment.obj.yaml
>   test/pecoff/Inputs/alternatename1.obj.yaml
>   test/pecoff/Inputs/alternatename2.obj.yaml
>   test/pecoff/Inputs/alternatename3.obj.yaml
>   test/pecoff/Inputs/armnt-ImageBase.obj.yaml
>   test/pecoff/Inputs/armnt-ImageBase.s
>   test/pecoff/Inputs/armnt-addr32-exec.obj.yaml
>   test/pecoff/Inputs/armnt-addr32-exec.s
>   test/pecoff/Inputs/armnt-addr32.obj.yaml
>   test/pecoff/Inputs/armnt-addr32.s
>   test/pecoff/Inputs/armnt-blx23t.obj.yaml
>   test/pecoff/Inputs/armnt-blx23t.s
>   test/pecoff/Inputs/armnt-branch24t.obj.yaml
>   test/pecoff/Inputs/armnt-branch24t.s
>   test/pecoff/Inputs/armnt-exports.def
>   test/pecoff/Inputs/armnt-exports.obj.yaml
>   test/pecoff/Inputs/armnt-import.obj.yaml
>   test/pecoff/Inputs/armnt-import.s
>   test/pecoff/Inputs/armnt-mov32t-exec.obj.yaml
>   test/pecoff/Inputs/armnt-mov32t-exec.s
>   test/pecoff/Inputs/armnt-mov32t.obj.yaml
>   test/pecoff/Inputs/armnt-mov32t.s
>   test/pecoff/Inputs/armnt-obj.s
>   test/pecoff/Inputs/armnt-obj.yaml
>   test/pecoff/Inputs/associative1.obj.yaml
>   test/pecoff/Inputs/associative3.obj.yaml
>   test/pecoff/Inputs/basereloc.obj.yaml
>   test/pecoff/Inputs/bss.asm
>   test/pecoff/Inputs/bss.obj
>   test/pecoff/Inputs/comdat.obj.yaml
>   test/pecoff/Inputs/common-symbol.obj.yaml
>   test/pecoff/Inputs/drectve.obj.yaml
>   test/pecoff/Inputs/drectve2.obj.yaml
>   test/pecoff/Inputs/drectve3.lib
>   test/pecoff/Inputs/entry.obj.yaml
>   test/pecoff/Inputs/executable.obj.yaml
>   test/pecoff/Inputs/executable.s
>   test/pecoff/Inputs/export.obj.yaml
>   test/pecoff/Inputs/exports.def
>   test/pecoff/Inputs/exports2.def
>   test/pecoff/Inputs/grouped-sections.asm
>   test/pecoff/Inputs/grouped-sections.obj.yaml
>   test/pecoff/Inputs/hello.asm
>   test/pecoff/Inputs/hello.obj.yaml
>   test/pecoff/Inputs/hello64.asm
>   test/pecoff/Inputs/hello64.obj.yaml
>   test/pecoff/Inputs/hello64lib.asm
>   test/pecoff/Inputs/hello64lib.lib
>   test/pecoff/Inputs/imagebase.obj.yaml
>   test/pecoff/Inputs/library.lib
>   test/pecoff/Inputs/machine-type-unknown.obj.yaml
>   test/pecoff/Inputs/main.obj.yaml
>   test/pecoff/Inputs/merge-largest1.obj.yaml
>   test/pecoff/Inputs/merge-largest2.obj.yaml
>   test/pecoff/Inputs/merge-same-size1.obj.yaml
>   test/pecoff/Inputs/merge-same-size2.obj.yaml
>   test/pecoff/Inputs/merge-same-size3.obj.yaml
>   test/pecoff/Inputs/nonstandard-sections.obj.yaml
>   test/pecoff/Inputs/nop.asm
>   test/pecoff/Inputs/nop.obj.yaml
>   test/pecoff/Inputs/nop64.obj.yaml
>   test/pecoff/Inputs/reloc.obj.yaml
>   test/pecoff/Inputs/reloc64.obj.yaml
>   test/pecoff/Inputs/resource.rc
>   test/pecoff/Inputs/resource.res
>   test/pecoff/Inputs/responsefile.txt
>   test/pecoff/Inputs/secrel1.obj.yaml
>   test/pecoff/Inputs/secrel2.obj.yaml
>   test/pecoff/Inputs/seh.c
>   test/pecoff/Inputs/seh.obj.yaml
>   test/pecoff/Inputs/static-data1.obj.yaml
>   test/pecoff/Inputs/static-data2.obj.yaml
>   test/pecoff/Inputs/static.lib
>   test/pecoff/Inputs/subsystem.main.yaml
>   test/pecoff/Inputs/subsystem.winmain.yaml
>   test/pecoff/Inputs/tlsused.obj.yaml
>   test/pecoff/Inputs/unknown-drectve.obj.yaml
>   test/pecoff/Inputs/unwind.obj.yaml
>   test/pecoff/Inputs/vars-main-x64.obj.yaml
>   test/pecoff/Inputs/vars-main-x86.obj.yaml
>   test/pecoff/Inputs/vars-main.c
>   test/pecoff/Inputs/vars.c
>   test/pecoff/Inputs/vars.dll.yaml
>   test/pecoff/Inputs/vars.lib
>   test/pecoff/Inputs/vars64.lib
>   test/pecoff/Inputs/weak-externals.asm
>   test/pecoff/Inputs/weak-externals.obj.yaml
>   test/pecoff/alignment.test
>   test/pecoff/alternatename.test
>   test/pecoff/armnt-ImageBase.test
>   test/pecoff/armnt-addr32-exec.test
>   test/pecoff/armnt-addr32.test
>   test/pecoff/armnt-address-of-entry-point.test
>   test/pecoff/armnt-blx23t.test
>   test/pecoff/armnt-branch24t.test
>   test/pecoff/armnt-exports.s
>   test/pecoff/armnt-exports.test
>   test/pecoff/armnt-imports.test
>   test/pecoff/armnt-mov32t-exec.test
>   test/pecoff/armnt-movt32t.test
>   test/pecoff/armnt.test
>   test/pecoff/associative.test
>   test/pecoff/base-reloc.test
>   test/pecoff/baseaddr.test
>   test/pecoff/bss-section.test
>   test/pecoff/comdat.test
>   test/pecoff/common-symbol.test
>   test/pecoff/conflicting-machine.test
>   test/pecoff/delayimport.test
>   test/pecoff/dll.test
>   test/pecoff/dosstub.test
>   test/pecoff/drectve.test
>   test/pecoff/dynamic.test
>   test/pecoff/dynamicbase.test
>   test/pecoff/entry.test
>   test/pecoff/export-warning.test
>   test/pecoff/export.test
>   test/pecoff/exportlib.test
>   test/pecoff/exportlib2.test
>   test/pecoff/grouped-sections.test
>   test/pecoff/hello.test
>   test/pecoff/hello64.test
>   test/pecoff/help.test
>   test/pecoff/imagebase.test
>   test/pecoff/importlib.test
>   test/pecoff/include.test
>   test/pecoff/lib.test
>   test/pecoff/libarg.test
>   test/pecoff/localyimported.test
>   test/pecoff/long-section-name.test
>   test/pecoff/machinetype.test
>   test/pecoff/manifest.test
>   test/pecoff/merge-largest.test
>   test/pecoff/merge-same-size.test
>   test/pecoff/multi.test
>   test/pecoff/noentry.test
>   test/pecoff/nonstandard-sections.test
>   test/pecoff/options.test
>   test/pecoff/pe32plus.test
>   test/pecoff/reloc.test
>   test/pecoff/reloc64.test
>   test/pecoff/resource.test
>   test/pecoff/responsefile.test
>   (14 more files...)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Davide

"A mathematical theory is not to be considered complete until you have
made it so clear that you can explain it to the first man whom you
meet on the street." (D. Hilbert)

More information about the llvm-commits mailing list