[PATCH] D10905: move DAGCombiner's allowableAlignment() helper function into the TLI

[Sanjay Patel]

spatel added a comment.

In http://reviews.llvm.org/D10905#214097, @jyknight wrote:

> I do still think it might be ultimately better and cleaner to not involve DataLayout at all, and to have the target hook describe the complete rules on what alignments can be loaded/stored, since DataLayout is really about the system's defined ABI, which can legitimately differ in different environments, even though the hardware's behavior does not. And I expect it'd actually be easier to understand that way as well.


Thanks, James and Quentin. I had considered Quentin's suggestion of making the hook virtual, but I'd prefer to do that when we have evidence that it's needed. That may come when I mess around with MergeConsecutiveStores() again. :)

I'll add a 'TODO' comment, so we have a reminder of this discussion in the code.


http://reviews.llvm.org/D10905