[PATCH] D11487: llvm-objdump --section, -j section filtering
Colin LeMahieu
colinl at codeaurora.org
Wed Jul 29 08:56:06 PDT 2015
colinl added inline comments.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:237
@@ +236,3 @@
+ if (error) {
+ return error.value();
+ }
----------------
filcab wrote:
> Is this an appropriate value to return?
The only other alternative I considered was returning a bool, otherwise the return types match exactly, int. Is there another possibility to consider?
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:243
@@ +242,3 @@
+ }
+ return 1;
+ },
----------------
filcab wrote:
> `return std::find(Sections.begin(), Sections.end(), String) == Sections.end();`
>
> (or `!= Sections.end()` if you switch the predicate around)
True, I'll make that change.
Repository:
rL LLVM
http://reviews.llvm.org/D11487
More information about the llvm-commits
mailing list