[PATCH] D11597: Add an ArgList::AddAllArgs that accepts a vector of OptSpecifier.

Douglas Katzman dougk at google.com
Wed Jul 29 08:35:47 PDT 2015


dougk created this revision.
dougk added reviewers: chandlerc, jyknight.
dougk added a subscriber: llvm-commits.

This lifts the somewhat arbitrary restriction on 3 OptSpecifiers.

http://reviews.llvm.org/D11597

Files:
  include/llvm/Option/ArgList.h
  lib/Option/ArgList.cpp

Index: lib/Option/ArgList.cpp
===================================================================
--- lib/Option/ArgList.cpp
+++ lib/Option/ArgList.cpp
@@ -258,6 +258,21 @@
   }
 }
 
+void ArgList::AddAllArgs(ArgStringList &Output,
+                         const std::vector<OptSpecifier> &Ids) const {
+  for (const Arg *Arg: Args) {
+    for (OptSpecifier Id : Ids) {
+      if (Arg->getOption().matches(Id)) {
+        Arg->claim();
+        Arg->render(*this, Output);
+        break;
+      }
+    }
+  }
+}
+
+/// This 3-arg variant of AddAllArgs could be eliminated in favor of one
+/// that accepts a single specifier, given the above which accepts any number.
 void ArgList::AddAllArgs(ArgStringList &Output, OptSpecifier Id0,
                          OptSpecifier Id1, OptSpecifier Id2) const {
   for (auto Arg: filtered(Id0, Id1, Id2)) {
Index: include/llvm/Option/ArgList.h
===================================================================
--- include/llvm/Option/ArgList.h
+++ include/llvm/Option/ArgList.h
@@ -259,6 +259,10 @@
   void AddLastArg(ArgStringList &Output, OptSpecifier Id0,
                   OptSpecifier Id1) const;
 
+  /// AddAllArgs - Render all arguments matching any of the given ids.
+  void AddAllArgs(ArgStringList &Output,
+                  const std::vector<OptSpecifier> &Ids) const;
+
   /// AddAllArgs - Render all arguments matching the given ids.
   void AddAllArgs(ArgStringList &Output, OptSpecifier Id0,
                   OptSpecifier Id1 = 0U, OptSpecifier Id2 = 0U) const;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11597.30911.patch
Type: text/x-patch
Size: 1529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150729/5fad9365/attachment.bin>


More information about the llvm-commits mailing list