[PATCH] D8817: Estimate DCE effect in heuristic for estimating complete-unroll optimization effects.

[Michael Zolotukhin]

mzolotukhin added a comment.

Hi Chandler,

I chose somewhat a hybrid approach between how it was implemented and what you suggested.

I did use a worklist to avoid one more visit of all instructions, but I decided not to count uses. I had in mind two reasons for that:

1. it would work incorrectly (or would require some special handling) with uses outside the loop - we won't count them and thus might think an instruction is dead, while it's not.
2. It would additionally complicate the code.

What do you think? Does it sound reasonable?

Michael


http://reviews.llvm.org/D8817