[PATCH] D11531: fix TLI's combineRepeatedFPDivisors interface to return the minimum user threshold

Chandler Carruth chandlerc at gmail.com
Tue Jul 28 15:20:23 PDT 2015


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM with one tweak.

If others want to keep bike-shedding this TTI interface, fine, but let's get this in because PR24141 is hitting us.


================
Comment at: include/llvm/Target/TargetLowering.h:2738
@@ -2738,1 +2737,3 @@
+  /// divisor uses that should exist before doing the transform in MinUses.
+  virtual bool combineRepeatedFPDivisors(unsigned &MinUses) const {
     return false;
----------------
Please make this return the minimum number of uses that should exist for this combine. "zero" is a pretty clear way to disable this IMO, as there is never a reason to combine anything with zero uses.


http://reviews.llvm.org/D11531







More information about the llvm-commits mailing list