[PATCH] D10905: move DAGCombiner's allowableAlignment() helper function into the TLI
Quentin Colombet
qcolombet at apple.com
Tue Jul 28 14:31:03 PDT 2015
qcolombet added inline comments.
================
Comment at: lib/CodeGen/TargetLoweringBase.cpp:1539
@@ +1538,3 @@
+ // Check if the specified alignment is sufficient based on the data layout.
+ Type *Ty = VT.getTypeForEVT(Context);
+ if (Alignment >= DL.getABITypeAlignment(Ty)) {
----------------
qcolombet wrote:
> I’d say that’s fine for the default behavior, but we could provide a way to change that at the target discretion by making the hook virtual.
Note: We could also do the virtual thing when we get an actual use case. I do not feel strongly either way.
http://reviews.llvm.org/D10905
More information about the llvm-commits
mailing list