[PATCH] D8304: Fix backward operands in call to isTruncateFree() and improve comments.
Steve King
kingshizzle at gmail.com
Tue Jul 28 12:33:56 PDT 2015
srking added inline comments.
================
Comment at: include/llvm/Target/TargetLowering.h:1558
@@ -1556,3 +1557,3 @@
/// Return true if any actual instruction that defines a value of type Ty1
/// implicitly zero-extends the value to Ty2 in the result register.
///
----------------
jroelofs wrote:
> s/Ty2/FromTy/ s/Ty1/ToTy/
rather s/Ty1/FromTy/ s/Ty2/ToTy/
================
Comment at: include/llvm/Target/TargetLowering.h:1562
@@ -1560,3 +1561,3 @@
/// as incoming arguments, or copies from unknown virtual registers. Also, if
/// isTruncateFree(Ty2, Ty1) is true, this does not necessarily apply to
/// truncate instructions. e.g. on x86-64, all instructions that define 32-bit
----------------
jroelofs wrote:
> s/Ty2/FromTy/ s/Ty1/ToTy/
I understand x86 behavior here, but I can't understand what the original comment is trying to say. Taking your word for it.
http://reviews.llvm.org/D8304
More information about the llvm-commits
mailing list