[PATCH] D11571: [MachO] Replace macho-dump with llvm-readobj in tests

[Davide Italiano]

davide created this revision.
davide added reviewers: echristo, rafael, grosbach.
davide added a subscriber: llvm-commits.
davide set the repository for this revision to rL LLVM.

The main reason why I brought up this review is understanding if the format provided by llvm-readobj -r is good enough for us.
macho-dump just dumps the raw words for each reloc while readobj prints something more human readable after processing.
I personally like llvm-readobj format a lot better, but I would like to hear other opinions.  An alternative would be that of introducing llvm-readobj --dump-raw-reloc-macho (maybe with a less cumbersome name), but I don't think it's really needed.

Repository:
  rL LLVM

http://reviews.llvm.org/D11571

Files:
  MC/AArch64/arm64-small-data-fixups.s

Index: MC/AArch64/arm64-small-data-fixups.s
===================================================================
--- MC/AArch64/arm64-small-data-fixups.s
+++ MC/AArch64/arm64-small-data-fixups.s
@@ -1,4 +1,4 @@
-; RUN: llvm-mc -triple arm64-apple-darwin -filetype=obj -o - %s | macho-dump | FileCheck %s
+; RUN: llvm-mc -triple arm64-apple-darwin -filetype=obj -o - %s | llvm-readobj -r | FileCheck %s
 
 foo:
   .long 0
@@ -9,16 +9,15 @@
   .byte foo - bar
   .short foo - bar
 
-; CHECK: # Relocation 0
-; CHECK: (('word-0', 0x9),
-; CHECK:  ('word-1', 0x1a000002)),
-; CHECK: # Relocation 1
-; CHECK: (('word-0', 0x9),
-; CHECK:  ('word-1', 0xa000001)),
-; CHECK: # Relocation 2
-; CHECK: (('word-0', 0x8),
-; CHECK:  ('word-1', 0x18000002)),
-; CHECK: # Relocation 3
-; CHECK: (('word-0', 0x8),
-; CHECK:  ('word-1', 0x8000001)),
-
+; CHECK: File: <stdin>
+; CHECK: Format: Mach-O arm64
+; CHECK: Arch: aarch64
+; CHECK: AddressSize: 64bit
+; CHECK: Relocations [
+; CHECK:  Section __text {
+; CHECK:    0x9 0 1 1 ARM64_RELOC_SUBTRACTOR 0 bar
+; CHECK:    0x9 0 1 1 ARM64_RELOC_UNSIGNED 0 foo
+; CHECK:    0x8 0 0 1 ARM64_RELOC_SUBTRACTOR 0 bar
+; CHECK:    0x8 0 0 1 ARM64_RELOC_UNSIGNED 0 foo
+; CHECK:  }
+; CHECK: ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11571.30843.patch
Type: text/x-patch
Size: 1224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150728/65059b04/attachment.bin>