[PATCH] D8304: Fix backward operands in call to isTruncateFree() and add asserts.

Jonathan Roelofs jonathan at codesourcery.com
Tue Jul 28 10:20:53 PDT 2015


jroelofs added a subscriber: jroelofs.

================
Comment at: include/llvm/Target/TargetLowering.h:1523
@@ -1521,3 +1522,3 @@
   /// values implicit zero-extend the result out to 64 bits.
   virtual bool isZExtFree(Type * /*Ty1*/, Type * /*Ty2*/) const {
     return false;
----------------
Please fix this one...

================
Comment at: include/llvm/Target/TargetLowering.h:1527
@@ -1525,3 +1526,3 @@
 
   virtual bool isZExtFree(EVT /*VT1*/, EVT /*VT2*/) const {
     return false;
----------------
... and this one too while you're here.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9152
@@ -9151,3 +9151,3 @@
       const TargetLowering &TLI = LS.DAG->getTargetLoweringInfo();
-      if (!TLI.isTruncateFree(LS.Inst->getValueType(0),
-                              LS.Inst->getOperand(0).getValueType()))
+      // isTruncateFree(FromType,ToType)
+      if (!TLI.isTruncateFree(LS.Inst->getOperand(0).getValueType(),
----------------
Drop this comment, and don't change the formatting of the following lines.


http://reviews.llvm.org/D8304







More information about the llvm-commits mailing list