[llvm] r243434 - Summary:

Martell Malone martellmalone at gmail.com
Tue Jul 28 09:52:11 PDT 2015


The first 2 lines are mixed up

Summary:
Object: add IMAGE_FILE_MACHINE_ARM64

should be

Object: add IMAGE_FILE_MACHINE_ARM64
Summary:


Is someone able todo
svn propset --revprop -r 243434 svn:log
to fix this as described here commit messages are not versioned properties
in svn
http://stackoverflow.com/questions/692851/can-i-go-back-and-edit-comments-on-an-svn-checkin


On Tue, Jul 28, 2015 at 5:18 PM, Martell Malone <martellmalone at gmail.com>
wrote:

> Author: martell
> Date: Tue Jul 28 11:18:17 2015
> New Revision: 243434
>
> URL: http://llvm.org/viewvc/llvm-project?rev=243434&view=rev
> Log:
> Summary:
> Object: add IMAGE_FILE_MACHINE_ARM64
>
> The official specifications state that the value of
> IMAGE_FILE_MACHINE_ARM64
> is 0xAA64 (as per the Microsoft Portable Executable and Common Object
> Format
> Specification v8.3).
>
> Reviewers: rnk
>
> Subscribers: llvm-commits, compnerd, ruiu
>
> Differential Revision: http://reviews.llvm.org/D11511
>
> Modified:
>     llvm/trunk/docs/yaml2obj.rst
>     llvm/trunk/include/llvm/Support/COFF.h
>     llvm/trunk/lib/Object/COFFObjectFile.cpp
>     llvm/trunk/lib/Object/COFFYAML.cpp
>
> Modified: llvm/trunk/docs/yaml2obj.rst
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/yaml2obj.rst?rev=243434&r1=243433&r2=243434&view=diff
>
> ==============================================================================
> --- llvm/trunk/docs/yaml2obj.rst (original)
> +++ llvm/trunk/docs/yaml2obj.rst Tue Jul 28 11:18:17 2015
> @@ -65,6 +65,7 @@ Here's a simplified Kwalify_ schema with
>                                   , IMAGE_FILE_MACHINE_AMD64
>                                   , IMAGE_FILE_MACHINE_ARM
>                                   , IMAGE_FILE_MACHINE_ARMNT
> +                                 , IMAGE_FILE_MACHINE_ARM64
>                                   , IMAGE_FILE_MACHINE_EBC
>                                   , IMAGE_FILE_MACHINE_I386
>                                   , IMAGE_FILE_MACHINE_IA64
>
> Modified: llvm/trunk/include/llvm/Support/COFF.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/COFF.h?rev=243434&r1=243433&r2=243434&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/COFF.h (original)
> +++ llvm/trunk/include/llvm/Support/COFF.h Tue Jul 28 11:18:17 2015
> @@ -88,6 +88,7 @@ namespace COFF {
>      IMAGE_FILE_MACHINE_AMD64     = 0x8664,
>      IMAGE_FILE_MACHINE_ARM       = 0x1C0,
>      IMAGE_FILE_MACHINE_ARMNT     = 0x1C4,
> +    IMAGE_FILE_MACHINE_ARM64     = 0xAA64,
>      IMAGE_FILE_MACHINE_EBC       = 0xEBC,
>      IMAGE_FILE_MACHINE_I386      = 0x14C,
>      IMAGE_FILE_MACHINE_IA64      = 0x200,
>
> Modified: llvm/trunk/lib/Object/COFFObjectFile.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/COFFObjectFile.cpp?rev=243434&r1=243433&r2=243434&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Object/COFFObjectFile.cpp (original)
> +++ llvm/trunk/lib/Object/COFFObjectFile.cpp Tue Jul 28 11:18:17 2015
> @@ -744,6 +744,8 @@ StringRef COFFObjectFile::getFileFormatN
>      return "COFF-x86-64";
>    case COFF::IMAGE_FILE_MACHINE_ARMNT:
>      return "COFF-ARM";
> +  case COFF::IMAGE_FILE_MACHINE_ARM64:
> +    return "COFF-ARM64";
>    default:
>      return "COFF-<unknown arch>";
>    }
> @@ -757,6 +759,8 @@ unsigned COFFObjectFile::getArch() const
>      return Triple::x86_64;
>    case COFF::IMAGE_FILE_MACHINE_ARMNT:
>      return Triple::thumb;
> +  case COFF::IMAGE_FILE_MACHINE_ARM64:
> +    return Triple::aarch64;
>    default:
>      return Triple::UnknownArch;
>    }
>
> Modified: llvm/trunk/lib/Object/COFFYAML.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/COFFYAML.cpp?rev=243434&r1=243433&r2=243434&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Object/COFFYAML.cpp (original)
> +++ llvm/trunk/lib/Object/COFFYAML.cpp Tue Jul 28 11:18:17 2015
> @@ -56,6 +56,7 @@ void ScalarEnumerationTraits<COFF::Machi
>    ECase(IMAGE_FILE_MACHINE_AMD64);
>    ECase(IMAGE_FILE_MACHINE_ARM);
>    ECase(IMAGE_FILE_MACHINE_ARMNT);
> +  ECase(IMAGE_FILE_MACHINE_ARM64);
>    ECase(IMAGE_FILE_MACHINE_EBC);
>    ECase(IMAGE_FILE_MACHINE_I386);
>    ECase(IMAGE_FILE_MACHINE_IA64);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150728/bbd99b67/attachment.html>


More information about the llvm-commits mailing list