[PATCH] D10964: [Codegen] Add intrinsics 'hadd*' and corresponding SDNodes for horizontal sum operation.

[Shahid]

ashahid added a comment.

Hi Bruno,

My response inlined.

Regards,
Shahid


================
Comment at: test/CodeGen/X86/vec-hadd-float-128.ll:2
@@ +1,3 @@
+; RUN:  llc < %s -mtriple=x86_64-unknown-linux-gnu -enable-unsafe-fp-math | FileCheck --check-prefix=UNSAFE %s
+
+
----------------
bruno wrote:
> Could you please update your tests to be more target neutral? I mean, use -mtriple=x86_64-unknown-unknown instead.
> 
> One question, what code does it emit if one removes -enable-unsafe-fp-math? If it currently makes no difference, you can remove it, otherwise you should be testing both versions.
Ok, will make it more target neutral accordingly.

In fact, user is not supposed to use float version of this intrinsic at all, if it is done so, compiler will 'assert'.


Repository:
  rL LLVM

http://reviews.llvm.org/D10964