[PATCH] D10707: Part 1 of 2-part patch: Use a specified list of languages in cmake project() command.

Reid Kleckner rnk at google.com
Mon Jul 27 13:42:28 PDT 2015


rnk added a subscriber: rnk.

================
Comment at: cmake/modules/HandleLLVMOptions.cmake:169
@@ -168,2 +168,3 @@
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${flag}" PARENT_SCOPE)
+    set(CMAKE_ASM_FLAGS "${CMAKE_ASM_FLAGS} ${flag}" PARENT_SCOPE)
   else()
----------------
This looks like it adds assembler flags without checking if the assembler supports them. What flags need to come through here? -mcpu? I think the list of flags that we need to pass to the assembler is probably shorter than the list of flags we pass to the compiler, and we might want to special case things in that direction.


http://reviews.llvm.org/D10707







More information about the llvm-commits mailing list