[PATCH] D10289: LoopStrengthReduce: Try to pass address space to isLegalAddressingMode

[Matt Arsenault]

arsenm added inline comments.

================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:3178
@@ -3152,1 +3177,3 @@
+        std::pair<size_t, int64_t> P = getUse(
+            S, LSRUse::Basic, MemAccessTy(nullptr, UNKNOWN_ADDRESS_SPACE));
         LF.LUIdx = P.first;
----------------
hfinkel wrote:
> MemAccessTy(nullptr, UNKNOWN_ADDRESS_SPACE) -> MemAccessTy()
> 
> (or do you want MemAccessTy::getUnknown()?)
This is nullptr because this is what it was using previously for the type. The existing code in some places uses void type and others use nullptr, and I'm not sure if there's a significant distinction between the uses. Changing this should be a separate change if worth doing


http://reviews.llvm.org/D10289