[PATCH] D11345: ignore duplicate divisor uses when transforming into reciprocal multiplies (PR24141)
Sanjay Patel
spatel at rotateright.com
Mon Jul 27 10:44:34 PDT 2015
spatel added a comment.
In http://reviews.llvm.org/D11345#212092, @hfinkel wrote:
> Part of the issue here is that we might walk all of the users even though TLI.combineRepeatedFPDivisors will return false for any size.
Ah, understood. I forgot the default return is always 'false'.
Let me split this up then:
1. Move the DAGCombiner's combineRepeatedFPDivisors logic into a helper function because it's getting too big (NFC).
2. Fix the TLI hook to return the minimum uses threshold (NFC).
3. Fix the data structure to be a SetVector to fix PR24141.
http://reviews.llvm.org/D11345
More information about the llvm-commits
mailing list