[PATCH] D11516: [mips][FastISel] Fix code generation for logical-ops by zero-extending constant operands.

Daniel Sanders daniel.sanders at imgtec.com
Mon Jul 27 06:36:28 PDT 2015


dsanders added a comment.

Could you show me the test case that required this change? The test cases in the patch aren't affected by whether the constant is sign or zero extended.

I suspect that (like an earlier bug in our fast isel involving shifts IIRC) the bug may be that an IR instruction that consumes the result of these bitwise operations is failing to emit a necessary zero extend prior to using it. For example, a comparison might not be zero extending to GPR-width before using it in setlt or similar.


http://reviews.llvm.org/D11516







More information about the llvm-commits mailing list