[PATCH] D9819: [TTI/CostModel] improve TTI::getGEPCost and use it in CostModel::getInstructionCost

hfinkel at anl.gov hfinkel at anl.gov
Sun Jul 26 06:45:19 PDT 2015


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:389
@@ +388,3 @@
+    if (Ptr != nullptr) {
+      // TODO: will remove this when a pointer can have an opaque type.
+      assert(Ptr->getType()->getScalarType()->getPointerElementType() ==
----------------
a pointer can have -> pointers have

(when we make the change, there will be no 'can' about it, they'll have to have an opaque type).


http://reviews.llvm.org/D9819







More information about the llvm-commits mailing list