[PATCH] D11124: Extracting a splat value from vector
hfinkel at anl.gov
hfinkel at anl.gov
Sun Jul 26 04:43:18 PDT 2015
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
This LGTM. Please either commit this with a test case covering the masks with undef (and the insertelement index verification), or add such a test case to http://reviews.llvm.org/D11121 before you commit.
================
Comment at: lib/Analysis/VectorUtils.cpp:428
@@ +427,3 @@
+ return nullptr;
+ // The fisrt shuffle source is 'insertelement' with index 0.
+ llvm::InsertElementInst *InsertEltInst =
----------------
fisrt -> first
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3092
@@ -3090,3 +3091,3 @@
assert (Ptr->getType()->isVectorTy() && "Uexpected pointer type");
GetElementPtrInst *Gep = dyn_cast<GetElementPtrInst>(Ptr);
if (!Gep || Gep->getNumOperands() > 2)
----------------
I'd highly prefer that Gep were GEP, GepPtrs -> GEPPtrs, etc. to match our general naming convention. But that should be done in a separate commit regardless.
Repository:
rL LLVM
http://reviews.llvm.org/D11124
More information about the llvm-commits
mailing list