[PATCH] D10161: [SCEV][LoopVectorize] Allow ScalarEvolution to make assumptions about overflows

hfinkel at anl.gov hfinkel at anl.gov
Sat Jul 25 17:52:48 PDT 2015


hfinkel added inline comments.

================
Comment at: include/llvm/Analysis/ScalarEvolutionExpressions.h:898
@@ +897,3 @@
+  static inline const OFAssumptionResult
+  removeOverflowsWithAssumptions(const SCEV *S, const Loop *L,
+                                 ScalarEvolution *SE) {
----------------
Why not make this a member function of SCEV (same for rewriteSCEVWithAssumptions below)?

================
Comment at: lib/Analysis/ScalarEvolution.cpp:8061
@@ -8060,3 +8198,2 @@
 //===----------------------------------------------------------------------===//
-
 ScalarEvolution::ScalarEvolution()
----------------
Don't remove blank line.


http://reviews.llvm.org/D10161







More information about the llvm-commits mailing list