I thought we prefered not to put const on Types. They don't have any
non-const methods anyway do they?
On Fri, Jul 24, 2015 at 12:19 PM, Pete Cooper <peter_cooper at apple.com>
wrote:
> Author: pete
> Date: Fri Jul 24 14:19:26 2015
> New Revision: 243146
>
> URL: http://llvm.org/viewvc/llvm-project?rev=243146&view=rev
> Log:
> Add const to some Type* parameters which didn't need to be mutable. NFC.
>
> We were only getting the size of the type which doesn't need to modify
> the type.
>
> Modified:
> llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
> llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=243146&r1=243145&r2=243146&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Fri Jul 24 14:19:26
> 2015
> @@ -925,22 +925,22 @@ PPCTargetLowering::PPCTargetLowering(con
>
> /// getMaxByValAlign - Helper for getByValTypeAlignment to determine
> /// the desired ByVal argument alignment.
> -static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign,
> +static void getMaxByValAlign(const Type *Ty, unsigned &MaxAlign,
> unsigned MaxMaxAlign) {
> if (MaxAlign == MaxMaxAlign)
> return;
> - if (VectorType *VTy = dyn_cast<VectorType>(Ty)) {
> + if (const VectorType *VTy = dyn_cast<VectorType>(Ty)) {
> if (MaxMaxAlign >= 32 && VTy->getBitWidth() >= 256)
> MaxAlign = 32;
> else if (VTy->getBitWidth() >= 128 && MaxAlign < 16)
> MaxAlign = 16;
> - } else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
> + } else if (const ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
> unsigned EltAlign = 0;
> getMaxByValAlign(ATy->getElementType(), EltAlign, MaxMaxAlign);
> if (EltAlign > MaxAlign)
> MaxAlign = EltAlign;
> - } else if (StructType *STy = dyn_cast<StructType>(Ty)) {
> - for (auto *EltTy : STy->elements()) {
> + } else if (const StructType *STy = dyn_cast<StructType>(Ty)) {
> + for (const auto *EltTy : STy->elements()) {
> unsigned EltAlign = 0;
> getMaxByValAlign(EltTy, EltAlign, MaxMaxAlign);
> if (EltAlign > MaxAlign)
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=243146&r1=243145&r2=243146&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Jul 24 14:19:26 2015
> @@ -1806,19 +1806,19 @@ EVT X86TargetLowering::getSetCCResultTyp
>
> /// Helper for getByValTypeAlignment to determine
> /// the desired ByVal argument alignment.
> -static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign) {
> +static void getMaxByValAlign(const Type *Ty, unsigned &MaxAlign) {
> if (MaxAlign == 16)
> return;
> - if (VectorType *VTy = dyn_cast<VectorType>(Ty)) {
> + if (const VectorType *VTy = dyn_cast<VectorType>(Ty)) {
> if (VTy->getBitWidth() == 128)
> MaxAlign = 16;
> - } else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
> + } else if (const ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
> unsigned EltAlign = 0;
> getMaxByValAlign(ATy->getElementType(), EltAlign);
> if (EltAlign > MaxAlign)
> MaxAlign = EltAlign;
> - } else if (StructType *STy = dyn_cast<StructType>(Ty)) {
> - for (auto *EltTy : STy->elements()) {
> + } else if (const StructType *STy = dyn_cast<StructType>(Ty)) {
> + for (const auto *EltTy : STy->elements()) {
> unsigned EltAlign = 0;
> getMaxByValAlign(EltTy, EltAlign);
> if (EltAlign > MaxAlign)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
--
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150725/94bb8af4/attachment.html>