[PATCH] D11485: [FIX] Delete incorrect CHECK in test Transforms/FunctionAttrs/noreturn.ll
Sergey Lisitsyn
fox9508 at ya.ru
Fri Jul 24 07:29:36 PDT 2015
lisitsynSA created this revision.
lisitsynSA added a reviewer: nadav.
lisitsynSA added subscribers: llvm-commits, zinovy.nis.
lisitsynSA set the repository for this revision to rL LLVM.
I made backport of "Fix a bug in mayHaveSideEffects. Functions that do not return are now considered as instructions with side effects." (http://llvm.org/viewvc/llvm-project?view=revision&revision=175553) to llvm 3.1 and found that test from this fix contained incorrect "CHECK: ret". This CHECK doesn't find ret but finds the word "noreturn" in attributes, so FileCheck passes.
; Function Attrs: noreturn nounwind ssp uwtable
define i32 @main() #1 {
entry:
tail call void @endless_loop()
unreachable
}
attributes #0 = { noreturn nounwind readnone ssp uwtable }
attributes #1 = { noreturn nounwind ssp uwtable }
The llvm 3.1 doesn't make attributes, so I found this inaccuracy.
Repository:
rL LLVM
http://reviews.llvm.org/D11485
Files:
test/Transforms/FunctionAttrs/noreturn.ll
Index: test/Transforms/FunctionAttrs/noreturn.ll
===================================================================
--- test/Transforms/FunctionAttrs/noreturn.ll
+++ test/Transforms/FunctionAttrs/noreturn.ll
@@ -9,7 +9,6 @@
}
;CHECK-LABEL: @main(
;CHECK: endless_loop
-;CHECK: ret
define i32 @main() noreturn nounwind ssp uwtable {
entry:
tail call void @endless_loop()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11485.30571.patch
Type: text/x-patch
Size: 379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150724/00efb5ef/attachment.bin>
More information about the llvm-commits
mailing list