[PATCH] D11492: DarwinAsmParser: Warn on multiple/mismatching version_min directives

Matthias Braun matze at braunis.de
Fri Jul 24 13:38:22 PDT 2015


MatzeB added a comment.

In http://reviews.llvm.org/D11492#211728, @steven_wu wrote:

> I am not sure if we should warn for UnknownOS. I guess there can be argument both way but we should at least have a test case for it. I am also not sure if you can run i386 asm parser when x86 backend is not built.


The "Triple::OSType ExpectedOS = Triple::UnknownOS;" initialization is only there to avoid uninitialized variable warnings, in practice you will always hit one of the switch cases below it.


Repository:
  rL LLVM

http://reviews.llvm.org/D11492







More information about the llvm-commits mailing list