[PATCH] D11484: [compiler] [tsan] Enable tsan for aarch64

[Evgeniy Stepanov]

eugenis added a comment.

Great job! I'll leave the real review to Dmitry. Just a few comments inline.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:267
@@ +266,3 @@
+  val = 1776;
+  if (val)
+    atomic_store(&kThreadDescriptorSize, val, memory_order_relaxed);
----------------
Looks like this if() is unnecessary, here and above.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:300
@@ -288,1 +299,3 @@
+# elif defined(__aarch64__)
+  descr_addr = reinterpret_cast<uptr>(__builtin_thread_pointer());
 # else
----------------
Clang does not recognize this builtin on aarch64. It looks like it only exists on arm. Are you building with gcc?



http://reviews.llvm.org/D11484