[PATCH] D11463: [AArch64] Define subtarget feature "reserve-x18"

[Eric Christopher]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Inline comment/question. Can be done as a followup if you'd like.

Thanks!

-eric


================
Comment at: lib/Target/AArch64/AArch64RegisterInfo.cpp:402-403
@@ -404,4 +401,4 @@
     return 32 - 1                                // XZR/SP
-           - (TFI->hasFP(MF) || TT.isOSDarwin()) // FP
-           - (TT.isOSDarwin() || ReserveX18) // X18 reserved as platform register
-           - hasBasePointer(MF);           // X19
+      - (TFI->hasFP(MF) || TT.isOSDarwin()) // FP
+      - (TT.isOSDarwin() ||
+         MF.getSubtarget<AArch64Subtarget>()
----------------
I wonder if the isOSDarwin parts here necessarily need to be here - should be able to fold them into either a) the subtarget feature existing, or b) the query in TFI?


http://reviews.llvm.org/D11463