[PATCH] Bitcode: Add bitcode format compatibility test

Sean Silva chisophugis at gmail.com
Thu Jul 23 22:03:08 PDT 2015


On Wed, Jul 22, 2015 at 3:10 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Not sure about everyone else, but I tried to add regression tests whenever
> I've changed the bitcode format, so I'm not sure how much it's necessary to
> have a generic test like this. I could imagine coverage isn't great & this
> might help - if it's easy to quantify, that might be interesting to know.
>

I think that the best way forward for bitcode compatibility is for an
interested party to set up a watch in Phabricator over all the
bitcode-related parts of the tree, then monitor it like a hawk and ensure
that all changes needing tests are tested.

-- Sean Silva


>
> On Wed, Jul 22, 2015 at 2:02 PM, Vedant Kumar <vsk at apple.com> wrote:
>
>> Successive versions of LLVM should retain the ability to parse bitcode
>> generated by old releases of the compiler. To that end, I've attached a
>> patch which contains a bitcode format compatibility test. It's set up as a
>> regression test. It achieves good coverage of the 3.7 LangRef (excepting a
>> bunch of intrinsics).
>>
>> The test consists of two files:
>>
>>     o test/Bitcode/compatibility-3.7.ll
>>     o test/Bitcode/compatibility-3.7.ll.bc
>>
>> We should always be able to disassemble the bitcode file and exactly
>> recover
>> the original IR.
>>
>> I've tried to stress as much of the LangRef as possible. I'm still trying
>> to find a good way of testing format compatibility for intrinsics.
>>
>> I'd have preferred to split this patch up into smaller ones, but since it
>> contains a binary file I thought it'd be best to get it done in one shot.
>> I
>> don't have commit rights, so I'd appreciate someone taking a look at the
>> patch and getting it into trunk :).
>>
>> thanks!
>> vedant
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150723/c9f7e245/attachment.html>


More information about the llvm-commits mailing list