Minor YAML enhancement

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu Jul 23 17:44:17 PDT 2015


> On 2015-Jul-22, at 10:14, Alex L <arphaman at gmail.com> wrote:
> 
> Hi Jonathan,
> I just posted a review comment for your patch.
> I think that for a patch like this it would make sense to look at git-blame and figure out who implemented YAML IO in LLVM, or who modified it last and then add them for review.
> Thanks,
> Alex

Alex, you've hacked on YAML enough I think once you think the patch
is okay, it's ready to commit :).

> 
> 2015-07-22 5:18 GMT-07:00 Jonathan Anderson <jonathan.anderson at mun.ca>:
> Good morning,
> 
> I’ve posted a patch to http://reviews.llvm.org/D11137 that adds another constructor to llvm::yaml::Input, passing filename information through to the llvm::yaml::Stream for debugging purposes. That is, if it fails to parse foo.yaml, it will now report an error having occurred at foo.yaml:7:1 rather than YAML:7:1.
> 
> I added a reviewer to http://reviews.llvm.org/D11137 based on the contents of CODE_OWNERS.txt a little over a week ago, but I haven’t heard any more since then. What’s the best way to find a reviewer for this change, other than the code ownership route?

Jonathan: to get a review, you need to send the patch to the mailing
list (llvm-commits at cs.uiuc.edu), ideally with `[PATCH]` at the start
of the subject and with the patch attached.  Feel free to CC
potential reviews based on the commit log, and then ping once a week
if you don't get a response.  The patch submission process is
documented here:
http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch
http://llvm.org/docs/DeveloperPolicy.html#code-reviews

It looks like you created a Phab revision, but didn't get the magic
quite right to have it send emails to the list for you.  Phab is
optional (some like it, some hate it).  Feel free to try again if
you prefer it; the magic to make it send emails correctly should be
documented here:
http://llvm.org/docs/Phabricator.html

(Or just send an email with the patch attached.)

> 
> Thanks,
> 
> Jonathan Anderson
> 
> Assistant Professor
> Electrical and Computer Engineering
> Memorial University of Newfoundland
> 
> http://www.engr.mun.ca/~anderson
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list